PDA

View Full Version : sunflow test parser bug


uncle_fungus
05-08-2008, 08:08 PM
I've just been running the universe test on one of my machines and I've noticed a bug in the parser which is similar to the scale problem identified in the md-gromacs test-set.

On fast machines, the result given isn't in seconds anymore, it's in milliseconds.
This leads to some stupid results for fast machines like the one I tested on. It reported times of 7000ms which the parser interprets as 7000s.

I'm looking into the parser now to work out how best to fix it.

uncle_fungus
05-08-2008, 09:01 PM
OK, this patch should fix the parser:

diff --git a/pts/test-resources/sunflow/parse-results.php b/pts/test-resources/sunflow/parse-results.php
index d2332d2..f4a3c1e 100644
--- a/pts/test-resources/sunflow/parse-results.php
+++ b/pts/test-resources/sunflow/parse-results.php
@@ -2,6 +2,11 @@

$BENCHMARK_RESULTS = substr($argv[1], strpos($argv[1], "Average:"));
$BENCHMARK_RESULTS = substr($BENCHMARK_RESULTS, 0, strpos($BENCHMARK_RESULTS, "\n"));
-echo trim(substr($BENCHMARK_RESULTS, strrpos($BENCHMARK_RESULTS, ':') + 1));
+preg_match( '/([0-9\.:]*)(.{0,2})/', trim(substr($BENCHMARK_RESULTS, strrpos($BENCHMARK_RESULTS, ':') + 1)), $match);
+
+if($match[2] == 'ms')
+ echo $match[1] / 1000;
+else
+ echo $match[1];

?>

Michael
05-08-2008, 10:42 PM
Fixed in git, thanks!