Tux3 Gets Harshly Criticized Over Code Quality

[phoronix]

Phoronix: Tux3 Gets Harshly Criticized Over Code Quality

On Friday the Tux3 file-system was called for review and offered to the mainline Linux kernel. Tux3 has been under development for more than six years but it seems that even after all this time and improvements, the code quality still isn't the best and the work is being scrutinized...

http://www.phoronix.com/vr.php?view=MTY5Mzk

[peppercats]

It's easy to take shots, why not submit some code to fix it?

[Gusar]

It's easy to take shots, why not submit some code to fix it?

Did you read the entire message? There's big fundamental issues, really big. "Some code" is not nearly enough, significant development is required.

[Spittie]

It's easy to take shots, why not submit some code to fix it?

Because that's the whole point of a code review, to read the code and see if there is anything wrong with it. Not to patch it up.
Also, why he should anyway? Since he's an XFS developer, I guess he's answer is to just use XFS.

[nanonyme]

Because that's the whole point of a code review, to read the code and see if there is anything wrong with it. Not to patch it up.
Also, why he should anyway? Since he's an XFS developer, I guess he's answer is to just use XFS.

Or Btrfs given how he said Tux3 takes largely same design decisions as Btrfs but is years behind.

[mark45]

Because that's the whole point of a code review, to read the code and see if there is anything wrong with it. Not to patch it up.
Also, why he should anyway? Since he's an XFS developer, I guess he's answer is to just use XFS.

Typo, not "he's answer", but "hease answer".

[xeekei]

Typo, not "he's answer", but "hease answer".

I'm sure you mean "his answer".

[mark45]

I'm sure you mean "his answer".

No, it's "hease", as in mine, yours, hease, ours, etc

[philip550c]

No, it's "hease", as in mine, yours, hease, ours, etc

hease is not a word.

[dee.]

Because that's the whole point of a code review,

Dave began, "I had a quick look at the code. This is not a code review

.....