RADV Spilling Support Patches Published

[phoronix]

Phoronix: RADV Spilling Support Patches Published

Bas Nieuwenhuizen has posted some new feature patches this weekend for the RADV Radeon Vulkan driver...

http://www.phoronix.com/scan.php?page=news_item&px=RADV-Spilling-Scratch-Memory

[ResponseWriter]

Great work! Thanks, Bas and Dave!

Are there any known missing features for Dota 2 or is it mainly performance and bug fixes left?

[andrei_me]

What the spilling do? Google gave me random results, like Guinness record

[BNieuwenhuizen]

What the spilling do? Google gave me random results, like Guinness record

Spilling is when not all the shader date fits in registers and the data "spills" over to memory. i.e. we have to allocate abuffer there and instruct the shader to store some of its temporary date there. Often very slow, but sometimes it just doesn't fit.

ResponseWriter: No missing features for dota2 IIRC.

[microcode]

Great work! Thanks, Bas and Dave!

Are there any known missing features for Dota 2 or is it mainly performance and bug fixes left?

DOTA 2 seems basically complete to me. I've run it a fair few times and it looks visually correct and hasn't crashed. I believe DOTA 2 was one of the first things they got working.

[humbug]

Good stuff, radv is iterating fast.

[andrei_me]

Spilling is when not all the shader date fits in registers and the data "spills" over to memory. i.e. we have to allocate abuffer there and instruct the shader to store some of its temporary date there. Often very slow, but sometimes it just doesn't fit.

Thanks for the reply, now I see how important this patches were

[nomadewolf]

Spilling is when not all the shader date fits in registers and the data "spills" over to memory. i.e. we have to allocate abuffer there and instruct the shader to store some of its temporary date there. Often very slow, but sometimes it just doesn't fit.

ResponseWriter: No missing features for dota2 IIRC.

So, can we expect this feature to actually have a negative impact in performance, for the games that need/use it?

[bridgman]

Yes, but the alternative is shaders not running, so overall it's still an improvement. AFAIK spilling is only done when required to run the app.

[ResponseWriter]

DOTA 2 seems basically complete to me. I've run it a fair few times and it looks visually correct and hasn't crashed. I believe DOTA 2 was one of the first things they got working.

Maybe, but there were definitely visual bugs when I last tried it. However, I'm on CIK so not officially supported by AMDGPU. I'll give it another go now.

Edit: Results in a total hang for me (black screen with mouse pointer). Only way to fix is hard reset. This may be worth looking into further.