IH ring buffer and ack of DCE irqs

Why don't we ack the DCE irqs in the IH ring buffer handler?

Quote:

---

Originally Posted by sylware

Why don't we ack the DCE irqs in the IH ring buffer handler?

---

We do. The irqs are acked in the irq_ack function (evergreen_irq_ack(), r600_irq_ack(), etc.) which is called from the irq handler ([evergreen|r600]_irq_process()).

Eh, sorry. I missed that. A geometric mean makes more sense, since we want to favour lower scores (lower scores tend to indicate some bottleneck, and us users notice the bottlenecks)http://www.slowliving.info/zhao3.jpghttp://www.slowliving.info/zhao2.jpghttp://www.slowliving.info/zhao4.jpg

Quote:

---

Originally Posted by agd5f

We do. The irqs are acked in the irq_ack function (evergreen_irq_ack(), r600_irq_ack(), etc.) which is called from the irq handler ([evergreen|r600]_irq_process()).

---

I have been missing my eye balls for a few days... :o