08-06-2010, 05:09 PM
On the other hand, having a test which uses the API in somewhat incorrect way is not bad either.
08-07-2010, 11:06 AM
08-07-2010, 01:48 PM
08-07-2010, 03:42 PM
I might open a new thread, but I came to think of the following:
In my vdpau backend, I am using some bits from the mplayer implementation to my bitstream parser. Well i know mplayer is GPL'ed and my code will be too, but do I have to copy any kind of license from the GPL'ed source file from mplayer into my code?
08-07-2010, 05:10 PM
I'm not a lawyer but I'd suspect loaning ideas from there is a just fine without any license concerns but loaning code not. Then again, whether or not these two things are equal is the bit where you decide on whether you want to take a guess which has its risks or hire an engineer with legal experience to sort the problem out for you.
08-07-2010, 05:28 PM
Well lets just say that I am using some of their bit parsing. I thought it would be easier just using their code, instead of me having to re-invent the wheel. It is basically only code such as:
Originally Posted by nanonyme
bitstream_parameter = bitstream << shift
08-07-2010, 06:22 PM
An incorrect test which is supposed to fail but doesn't crash a GPU or Mesa means that Mesa/GPU passes and handles the incorrectness correctly. :P
Concerning the licensing issues, you can't copy a GPL code and commit it in Mesa.
08-08-2010, 09:45 AM
FYI, I submitted the patches here:
just in case anyone wants to re-test with r300g, since I only tested them on nvidia.
08-08-2010, 11:14 AM
08-08-2010, 12:17 PM
Looks rather good to me. I'm still suspicious about the gear not looking quite symmetric but I might just be imagining it.
Originally Posted by rohcQaH