Page 2 of 2 FirstFirst 12
Results 11 to 12 of 12

Thread: Nouveau Driver Gets Fan Control Modes

  1. #11
    Join Date
    Feb 2008
    Location
    Linuxland
    Posts
    5,338

    Default

    One option is badly named. "none" implies off, it would be better as "bios", or "default".

    Please fix before it's in kernel and can't be changed

  2. #12
    Join Date
    Feb 2009
    Location
    France
    Posts
    309

    Default

    Quote Originally Posted by curaga View Post
    One option is badly named. "none" implies off, it would be better as "bios", or "default".

    Please fix before it's in kernel and can't be changed
    Hey, I understand your complain but not matter what name I find, they are all confusing in some way. In the case of "bios" or "default", it doesn't express that you leave it in this state.
    With FAN_CTRL_NONE, it really means that there is no control and thus, the fan is left untouched. For now, this mode is the default, but starting from next kernel, I will push for auto fan management as a default.

    Anyway, it shouldn't matter as this name is internal only. The user has to use the sysfs interface which uses numbers (as specified in the hwmon interface http://www.mjmwired.net/kernel/Docum...-interface#250).

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •